Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipAuthors (boolean) option #183

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kleinpetr
Copy link
Contributor

Resolves #174

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

the new option --skipAuthors to avoid Contributors section

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test: add test for skipAuthors option
test: add test commits fixture

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

hrynevychroman

This comment was marked as off-topic.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Philipp Kief <[email protected]>
@kleinpetr kleinpetr requested a review from PKief November 13, 2024 12:46
@kleinpetr
Copy link
Contributor Author

@PKief don't understand why but all the tests pass locally but not in the ci

@pi0
Copy link
Member

pi0 commented Nov 13, 2024

@kleinpetr it is a snapshot mismatch, please don't worry about it will check before merge. And again sorry this PR got delayed this much I had been busy on so many other projects.

@PKief
Copy link

PKief commented Nov 13, 2024

@PKief don't understand why but all the tests pass locally but not in the ci

Something looks a little weird, because the CI expects this line to be part of the snapshot:

image

Locally, it's working fine for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide contributors
4 participants