-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tz deprecation #972
fix tz deprecation #972
Conversation
Codecov ReportBase: 96.69% // Head: 96.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 96.69% 96.76% +0.07%
==========================================
Files 42 42
Lines 4201 4231 +30
==========================================
+ Hits 4062 4094 +32
+ Misses 139 137 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thanks @cristianmatache! mind adding a test for this in https://github.com/unionai-oss/pandera/blob/master/tests/core/test_dtypes.py ? |
yes sir |
pandera/engines/pandas_engine.py
Outdated
and pandas_dtype.tz is not None | ||
and col.dt.tz is None | ||
): | ||
col = col.dt.tz_localize(pandas_dtype.tz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristianmatache can we add a test case that executes this conditional? i.e. a case where the schema dtype is timezone aware but the data column isn't?
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
fixes #971