Support Unicode 15.1 #124
Merged
Support Unicode 15.1 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
unicode-15-1
branch
5 times, most recently
from
83dcbc1 to
a909537
Compare
|
I originally described a categorization issue with - turns out the Unicode data files are correct, I was just using outdated ones. Oops. I kept the tests that verify (and the Syriac abbreviation mark) are categorized correctly. |
Manishearth
reviewed
Sep 25, 2023
| run: ./scripts/unicode.py && diff tables.rs src/tables.rs |
There was a problem hiding this comment.
sweet, thanks for adding this. I've been adding this for the other unicode- crates bit by bit
Manishearth
approved these changes
Sep 25, 2023
Manishearth
reviewed
Sep 25, 2023
| @@ -50,6 +50,9 @@ fn test_graphemes() { | |||
| ]; | |||
|
|
|||
| for &(s, g) in TEST_SAME.iter().chain(EXTRA_SAME) { | |||
| if s.starts_with("क\u{94d}") || s.starts_with("क\u{93c}") { | |||
| continue; // TODO: fix these | |||
There was a problem hiding this comment.
please file an issue for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Unicode 15.1 support.
Updating tests
Turns out
scripts/unicode_gen_breaktests.pywas last run for Unicode 11 - every subsequent updater forgot to run it. I updated the GitHub Action that checksscripts/unicode.pywas run to also check forscripts/unicode_gen_breaktests.pybeing run.Devanagari mis-segmentation
There are a few cases where Devanagari grapheme segmentation fails after updating the test data from Unicode 11 to Unicode 15. I just skipped those failing tests for now.