Skip to content

Commit

Permalink
ICU-22874 Remove now obsolete -Wstrict-prototypes workarounds.
Browse files Browse the repository at this point in the history
  • Loading branch information
roubert committed Sep 16, 2024
1 parent 5c02662 commit 688957e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/icu4c.yml
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ jobs:
CC: clang-16
CXX: clang++-16
# TODO: add '-Werror' after fixing ICU-22873
CPPFLAGS: '-Wall -Wextra -Wno-strict-prototypes -Wctad-maybe-unsupported'
CPPFLAGS: '-Wall -Wextra -Wctad-maybe-unsupported'
CXXFLAGS: ${{ matrix.flags }}
run: |
cd icu4c/source && ./runConfigureICU --enable-debug --disable-release Linux/clang && make -j -l4.5 check
Expand All @@ -348,7 +348,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: ICU4C with clang on MacOS
env:
CPPFLAGS: '-Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor -Wctad-maybe-unsupported -Werror -Wno-error=strict-prototypes'
CPPFLAGS: '-Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor -Wctad-maybe-unsupported -Werror'
run: |
cd icu4c/source;
PYTHON=python3 ./runConfigureICU macOS;
Expand Down

0 comments on commit 688957e

Please sign in to comment.