Skip to content

Commit

Permalink
ICU-22502 Fix TestPersonNames failure on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
yumaoka committed Sep 20, 2023
1 parent c4a596e commit 2f70902
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package com.ibm.icu.dev.test.format;

import java.io.*;
import java.nio.charset.StandardCharsets;
import java.util.*;

import com.ibm.icu.dev.test.TestFmwk;
Expand Down Expand Up @@ -69,7 +70,7 @@ static List<String> readTestCases() throws Exception {
@Parameters(method = "readTestCases")
public void TestPersonNames(String filename) throws IOException {
String knownIssue = KNOWN_ISSUES.get(filename);
LineNumberReader in = new LineNumberReader(new InputStreamReader(TestUtil.class.getResourceAsStream(DATA_PATH + filename)));
LineNumberReader in = new LineNumberReader(new InputStreamReader(TestUtil.class.getResourceAsStream(DATA_PATH + filename), StandardCharsets.UTF_8));
String line = null;
PersonNameTester tester = new PersonNameTester(filename);

Expand Down

1 comment on commit 2f70902

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2f70902 Previous: c4a596e Ratio
TestCharsetEncoderICU 10.17558777351618 ns/iter 4.0545006858312025 ns/iter 2.51

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.