Test handle method returns false on invalid mime type

unclexo · Jan 28, 2023 · 2ff6ae5 · 2ff6ae5
1 parent 5ff4b35
commit 2ff6ae5
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/app/Jobs/ImageUploadAndResizingJob.php b/app/Jobs/ImageUploadAndResizingJob.php
@@ -25,6 +25,8 @@ class ImageUploadAndResizingJob implements ShouldQueue
         '640x480' => [640, 480],
     ];
 
+    public array $allowedExtension = ['jpg', 'jpeg', 'png'];
+
     private ?Filesystem $storage;
 
     /**
@@ -55,6 +57,10 @@ public function storage()
     public function handle()
     {
         $path = 'fake-image-name.jpg';
+
+        if (! $this->isAllowedExtension($this->getExtensionFromMimeType())) {
+            return false;
+        }
 
         if (! $this->storage()->put($path, base64_decode($this->imageContent))) {
             return false;
@@ -73,6 +79,21 @@ public function handle()
         return $paths;
     }
 
+    private function isAllowedExtension(string $extension)
+    {
+        return in_array($extension, $this->allowedExtension);
+    }
+
+    private function getExtensionFromMimeType()
+    {
+        if (! preg_match("/^[a-z]+\/[a-z0-9\.\+-]+$/", $this->mimeType))
+            return false;
+
+        [, $extension] = explode('/', $this->mimeType);
+
+        return $extension;
+    }
+
     /**
      * Modify an absolute path for renaming image name with resolution key
      *

diff --git a/tests/Feature/JobTest.php b/tests/Feature/JobTest.php
@@ -77,4 +77,14 @@ public function handle_method_returns_false_on_upload_fail()
 
         $this->assertFalse($job->handle());
     }
+
+    /** @test */
+    public function handle_method_returns_false_on_invalid_mime_type()
+    {
+        $file = UploadedFile::fake()->create('file.txt', '10', 'text/plain');
+
+        $job = new ImageUploadAndResizingJob($file->getMimeType(), base64_encode($file->getContent()));
+
+        $this->assertFalse($job->handle());
+    }
 }