This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
fix(wallet): handle binary psbt properly #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucko13
approved these changes
Mar 16, 2021
!| // If the binary -> hex conversion starts with this magic number, we're | ||
| // good to go. Otherwise - it was likely not a binary file, meaning | ||
| // it was is probably base64 or hex, so we should try using text instead. | ||
| if (psbtHex.startsWith(PSBT_MAGIC_HEX)) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per spec
psbtfile is actually in binary. Support this while continuing to support base64/hex as well.Does this PR introduce a breaking change?
Does this PR fix an open issue?