Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

fix(other): fix npm packages with low severity vulnerabilities #167

Merged

Conversation

abhiShandy
Copy link
Contributor

5000 low severity vulnerabilities were found while installing node modules. Such a message might intimidate uninformed users, so I bumped the dependencies to fix all but one vulnerability without breaking the code.

Description

I simply ran npm audit fix to bump the versions of dependencies with vulnerabilities, and committed the package*.json

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fix an open issue?

Similar to #134

  • Yes
  • No

5000 low severity vulnerabilities are shown during `npm install` which might be intimidating for
uninformed users

ISSUES: unchained-capital#134
Copy link
Contributor

@waldenraines waldenraines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did a quick regression test run and everything worked well.

Thanks for the PR @abhiShandy !

@waldenraines waldenraines merged commit 44cedd0 into unchained-capital:master Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants