Fix isascii() method calls for python 3.6
#4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenn-jocher
changed the title
isascii() method calls for python 3.6
|
@d57montes good catch! PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
CesarBazanAV
pushed a commit
to CesarBazanAV/yolov5
that referenced
this pull request
Sep 29, 2021
* fix isascii for python3.6 * update comment with python 3.7 note Co-authored-by: Glenn Jocher <[email protected]>
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* fix isascii for python3.6 * update comment with python 3.7 note Co-authored-by: Glenn Jocher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
str.isascii()method was introduced in python3.7, so this changes it back to using the utils functionis_asciito continue supporting python3.6.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancement in string character encoding checks and annotations in YOLOv5.
📊 Key Changes
is_asciito check if a string is composed only of ASCII characters..isascii()string method with the newis_asciifunction within the annotation classAnnotator.🎯 Purpose & Impact
is_asciiaims to provide compatibility for Python versions older than 3.7, which do not have the.isascii()method for strings.