fix: Uncaught TypeError on renderer tiptap react issue #5870 #5871
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
reviewed
Nov 26, 2024
| @@ -193,13 +193,13 @@ export class ReactNodeView< | |||
| } | |||
|
|
|||
| if (from <= pos && to >= pos + this.node.nodeSize) { | |||
| if (this.renderer.props.selected) { | |||
| if (this?.renderer?.props?.selected) { | |||
There was a problem hiding this comment.
The renderer should always be there no? even destroy kills the instance but does not null it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Adds null coalescing operators to
this.renderer.props.selectedin order to handle intermittent cases where the renderer might be undefined due to lifecycle issuesImplementation Approach
Simple null coalescing operators
Testing Done
Attempted to replicate the crash in #5870 after applying the changes
Verification Steps
Crash should no longer be reproducible.
Additional Notes
Checklist
Related Issues
#5870