Audio recording in media importer #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a built-in media recorder option to the media importer.
Note: this uses the mediaRecorder interface which is relatively new. It has cross-browser support, but a few quirks: there may be browser compatibility issues related to the audio format(s) used for recording.
audio/webm; codecs=opusis hard-coded as the MIME type due to general compatibility.Additionally, the blobs generated by the
mediaRecorderinterface due not contain duration metadata. This is apparently a bug in chromium that has previously been tagged aswontfixdue to it being "by design". Instead, I had to use a fix-webm-duration package that reads the blob after recording has stopped and returns a modified blob that includes the correct duration information.Replacement for #1527 since that was accidentally closed when I deleted
dev/10.0.1before changing the original PR's base branch.