-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React branch] Fixes and polish part five #1492
[React branch] Fixes and polish part five #1492
Conversation
…copy url binding in instance admin
…sub-components, significant style rework of score screen
…e rendering with custom score screens
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! This might be a good PR too to push a few quick fixes to other score screen issues, such as the missing Preview/Play again button. There are also a couple useEffects that could be reduced to just setting the enabled
attribute on the query itself to the dependency, such as loadPlayScores
and possibly loadGuestScores
and loadInstanceScores
.
setAttributes({ | ||
...attributes, | ||
hidePlayAgain: true | ||
}) | ||
} | ||
} | ||
}, [attemptsLeft]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a race condition here with instance
and single_id
being undefined when attemptsLeft
has loaded. Possible fix is to add instance
as a dependency.
The check for !single_id
also seems unnecessary, since it will still pass even when it is null or undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the sanity check. This got rearranged so that setAttemptsLeft
is only assigned when the apiGetWidgetInstanceScores
query resolves, which itself is predicated on instance
existing.
@cayb0rg I can't believe I overlooked the missing Preview Again button, but do you have examples of when the Play Again button should be present and isn't? |
Play Again is missing when a widget is set to Guest Mode, because Adding |
The only other things I see are incredibly minor.
|
…reSummary graph on single id score screens
|
…since last save in creator action bar
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the widget catalog filter options still being kind of a hassle to figure out for unsighted users, but I don't really have any ideas for how to fix it and everything within the scope of this PR looks good.
…nager Adds user role manager to user admin interface
1d8ffbf
into
ucfopen:issue/support-dashboard-in-react
Bug fixes:
useUpdatedWidget
mutationImprovements:
Scores
component, including splitting logic into childScoreOverview
,ScoreDetails
, andScoreGraphic
components