fix(compatibility): change react and reactdom to peer dependencies #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React changed the way setState callbacks are handled in version 16. When using react-geosuggest with React < 16 the callbacks were no longer called. In order to maintain compatibility with React 0.14 and 15, React and ReactDOM have been moved to peer dependencies. Closes ubilabs#405
ro-ka
suggested changes
Oct 26, 2018
|
Indentation and packages should be fixed now. |
ro-ka
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Including React and ReactDOM as dependencies was causing the latest version to no longer function when used with React 0.14 and 15.0. See #405. This was due to a breaking change in the way React handles the callback for setState (see here: https://stackoverflow.com/a/48375265/1054890)
The fix was to remove React and ReactDOM as direct dependencies and move them to being peer dependencies. This should be fine, as any project using this component should already have React / ReactDOM as a direct dependency.
Because they are now peer dependencies, the example has been updated to use the versions available via the React CDN links.
Checklist