Clean various compile warnings #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important ones being the changes in IntelliJType.kt; the old ones are marked for removal.
jbarr21
reviewed
Dec 14, 2023
| @@ -105,8 +105,7 @@ object XOverrides { | |||
| // one that declares the same method, and check that we haven't reached mA. We compare | |||
| // the enclosing elements rather than the methods themselves for the reason described | |||
| // at the start of the method. | |||
| var inherited: XMethodElement? = null | |||
| (inherited != null && overridden.enclosingElement != inherited.enclosingElement) | |||
| false | |||
There was a problem hiding this comment.
please be sure to test a local build of this in monorepo before we land this
There was a problem hiding this comment.
Confirmed that all three of uber's big apps (rider / uber eats / driver) can be built with a motif version running the commit at 5a79929
jbarr21
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following minor updates:
IntelliJType.kt