-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BAD Example in import-alias.md
#220
Conversation
This update refines the BAD example in import-alias.md to better illustrate improper usage of import aliases, making it easier for readers to understand and learn from the mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
One minor change: std imports are grouped together:
import (
"fmt"
"os"
runtimetrace "runtime/trace"
nettrace "golang.net/x/trace"
)
std imports are grouped together:
done @abhinav |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Uber folks will probably need you to sign the CLA before they can merge this, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this PR. As @abhinav pointed out, if you could please sign the CLA we can merge this.
This update refines the BAD example in
import-alias.md
to better illustrate improper usage of import aliases, making it easier for readers to understand and learn from the mistake.