Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BAD Example in import-alias.md #220

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Conversation

martinyonatann
Copy link
Contributor

This update refines the BAD example in import-alias.md to better illustrate improper usage of import aliases, making it easier for readers to understand and learn from the mistake.

This update refines the BAD example in import-alias.md to better illustrate improper usage of import aliases, making it easier for readers to understand and learn from the mistake.
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
One minor change: std imports are grouped together:

import (
  "fmt"
  "os"
  runtimetrace "runtime/trace"

  nettrace "golang.net/x/trace"
)

martinyonatann and others added 2 commits November 17, 2024 01:05
std imports are grouped together:
@martinyonatann
Copy link
Contributor Author

martinyonatann commented Nov 16, 2024

One minor change: std imports are grouped together:

done @abhinav

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Uber folks will probably need you to sign the CLA before they can merge this, though.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for this PR. As @abhinav pointed out, if you could please sign the CLA we can merge this.

@martinyonatann
Copy link
Contributor Author

Thank you for pointing that out! I’ve already signed the CLA, so it should be all set. Please let me know if there’s anything else I need to do to assist with the merge. @sywhang @abhinav

@sywhang sywhang merged commit 62b6af7 into uber-go:master Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants