Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stack in set.js #2783

Open
8 tasks done
Yuki2718 opened this issue Aug 22, 2023 · 2 comments
Open
8 tasks done

Support stack in set.js #2783

Yuki2718 opened this issue Aug 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Yuki2718
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

AG supports this: https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#set-constant

A specific URL where the issue occurs.

NA

Steps to Reproduce

NA

Expected behavior

NA

Actual behavior

NA

uBO version

1.51.0

Browser name and version

Firefox 116.0.3

Operating System and version

Windows 10
gorhill added a commit to gorhill/uBlock that referenced this issue Aug 22, 2023
@gorhill
Re-factor extra args for set-constant scriptlet
f407c28 
To prepare for better compatibility with AdGuard's own `set-constant`
scriptlet.

The 3rd position parameter which dictates how to set the value has
been converted into a vararg paramater, as follow:

  ..., as, function
  ..., as, callback
  ..., as, resolved
  ..., as, rejected

Similarly, the parameter used to dictate when the scriptlet
should become effective is now to be used as a vararg:

  ..., runAt, load

Related issue:
uBlockOrigin/uBlock-issues#2783

Ideally, AdGuard would support its `stack` parameter as a
vararg, to be discussed.
@gorhill
Copy link
Member

gorhill commented Aug 22, 2023

gorhill/uBlock@f407c28

@uBlock-user uBlock-user added enhancement New feature or request fixed issue has been addressed labels Aug 24, 2023
@garry-ut99 garry-ut99 mentioned this issue Jul 1, 2024
Closed
@D4niloMR
Copy link

Will the set-constant scriptlet support stack parameter? I added ##+js(set, Math.random, 1, as, function) to not use rpnt on https://rsshort.com/qyoHMov but it breaks the Cloudflare captcha.

@gorhill gorhill reopened this Oct 28, 2024
@uBlock-user uBlock-user removed the fixed issue has been addressed label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhill @uBlock-user @Yuki2718 @D4niloMR