Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force remove DNS input from Captive portal #1733

Open
JuniorLopasso opened this issue Apr 10, 2024 · 0 comments
Open

Force remove DNS input from Captive portal #1733

JuniorLopasso opened this issue Apr 10, 2024 · 0 comments
Labels
bug Validated BUG

Comments

@JuniorLopasso
Copy link

Basic Infos

Hardware

WiFimanager Branch/Release: Master

Esp8266/Esp32: Esp32

Hardware: ESP32-WROOM-32-D

Core Version: 2.0.14

Description

I needed to inherit the Wifimanager class in my project and saw a problem when I tried to force the IP fields to be disabled.

On line 2968 of the WiFiManager.cpp file, I think someone forgot to add an “else” statement at the beginning of the line.

It is:
_staShowDns = alwaysShow? 1: 0;

and it should be:
else _staShowDns = alwaysShow? 1: 0;

I hope I helped you with this.

Settings in IDE

Module: NodeMcu

Additional libraries:
knolleary/PubSubClient@^2.8
bblanchon/ArduinoJson@^6.21.2

Sketch

---

Debug Messages

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Validated BUG
Projects
None yet
Development

No branches or pull requests

2 participants