Fix various issues #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error generated when multiple blacklist items are in the map:
Error: INSTALLATION FAILED: template: matrix/templates/synapse/deployment.yaml:20:36: executing "matrix/templates/synapse/deployment.yaml" at <include (print $.Template.BasePath "/synapse/configmap.yaml") .>: error calling include: template: matrix/templates/synapse/configmap.yaml:10:7: executing "matrix/templates/synapse/configmap.yaml" at <include "homeserver.yaml" .>: error calling include: template: matrix/templates/synapse/_homeserver.yaml:835:18: executing "homeserver.yaml" at <.Values.matrix.urlPreviews.rules.url.blacklist>: wrong type for value; expected string; got []interface {}
|
There are numerous templating issues with the configmap for synapse as well that i'm currently untangling :/ |
Fixes garbled generation of configmap caused by unquoted substitution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Fix improper url blacklist inclusion
Fixes the following error generated when multiple blacklist items are in the map:
Error: INSTALLATION FAILED: template: matrix/templates/synapse/deployment.yaml:20:36: executing "matrix/templates/synapse/deployment.yaml" at <include (print $.Template.BasePath "/synapse/configmap.yaml") .>: error calling include: template: matrix/templates/synapse/configmap.yaml:10:7: executing "matrix/templates/synapse/configmap.yaml" at <include "homeserver.yaml" .>: error calling include: template: matrix/templates/synapse/_homeserver.yaml:835:18: executing "homeserver.yaml" at <.Values.matrix.urlPreviews.rules.url.blacklist>: wrong type for value; expected string; got []interface {}
(2) Fix bad exim relay settings
Bad logic results in 'relay.enabled' always being evaluated to true