feat: add optional matcher function for ArrayUnique decorator #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diluka
changed the title
when identifer function supplied, the comparison will base on the mapped array. close #602
| if (!(array instanceof Array)) return false; | ||
|
|
||
| if (identifier) { | ||
| array = array.map(o => (o != null ? identifier(o) : o)); |
There was a problem hiding this comment.
Why do you check for null here before calling the identifier function?
There was a problem hiding this comment.
check null before calling or check null in every identifier function. I just pick the former
NoNameProvided
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when identifer function supplied,
the comparison will base on the mapped array.
close #602
Description
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #[issue number], fixes #[issue number]