Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use optional chaining in ValidationArguments before accessing their value #1776

Merged

Conversation

NoNameProvided
Copy link
Member

Description

This PR updates the access on validation arguments in each decorator to use the safe args?. format.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

none

@NoNameProvided NoNameProvided mentioned this pull request Nov 13, 2022
6 tasks
@NoNameProvided NoNameProvided changed the title fix: typing fix: add optional chaining to ValidationArguments in each decorator Nov 13, 2022
@NoNameProvided NoNameProvided changed the title fix: add optional chaining to ValidationArguments in each decorator fix: use optional chaining in ValidationArguments before accessing their value Nov 13, 2022
@NoNameProvided NoNameProvided merged commit 3a2bfec into develop Nov 13, 2022
@NoNameProvided NoNameProvided deleted the fix/access-validation-args-safely-in-decorators branch November 13, 2022 12:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants