-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trim input in @IsEnum
decorator before comparsion
#1700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kundkingan
approved these changes
Aug 1, 2022
jotamorais
pushed a commit
to jotamorais/class-validator
that referenced
this pull request
Oct 7, 2022
…but it the function isn't always available in the anonymous/generic type
NoNameProvided
force-pushed
the
develop
branch
from
November 13, 2022 11:46
2ef8ff0
to
0da8f89
Compare
This is something we don't want. If you need this you can use it as a custom decorator. |
NoNameProvided
changed the title
fix: enum string trim support for @IsEnum
fix: trim input in Nov 20, 2022
@IsEnum
decorator before comparsion
NoNameProvided
changed the title
fix: trim input in
feat: trim input in Nov 20, 2022
@IsEnum
decorator before comparsion@IsEnum
decorator before comparsion
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied trim on enum string to remove unnecessary white space for
@IsEnum()
decorator.Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
none