Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: correction in README.md codeblocks, fix error "validationOptions can not be undefined" when creating custom class validators #1643

Closed
wants to merge 102 commits into from

Conversation

ashuvssut
Copy link

@ashuvssut ashuvssut commented May 10, 2022

when creating custom class validators, validationOptions can not be undefined.
It gives off this error: Type 'undefined' is not assignable to type 'ValidationOptions'. (REF issue #1642)

Correction in documentation: the validationOption argument from custom validation decorator functions is now not allowed to be optional.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated

fixes #1642

dependabot bot added 30 commits November 22, 2021 09:06
dependabot bot and others added 22 commits March 7, 2022 09:07
when creating custom class validators, `validationOptions` can not be undefined. It gives off this error: `Type 'undefined' is not assignable to type 'ValidationOptions'.`
so the validationOption argument from custom validation decorator functions is now not allowed to be optional.
@NoNameProvided
Copy link
Member

The change is invalid, the parameter is optional.

@ashuvssut
Copy link
Author

This PR was created for Issue #1642. I have given my issue details there in that Issue

But, this issue is too old now and I am no longer working on that project. Therefore I think I will be closing issue #1642.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: invalid / expired Issues with no action to take.
Development

Successfully merging this pull request may close these issues.

fix: Type 'undefined' is not assignable to type 'ValidationOptions'. when creating validation decorators
2 participants