-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: correction in README.md codeblocks, fix error "validationOptions
can not be undefined" when creating custom class validators
#1643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when creating custom class validators, `validationOptions` can not be undefined. It gives off this error: `Type 'undefined' is not assignable to type 'ValidationOptions'.` so the validationOption argument from custom validation decorator functions is now not allowed to be optional.
NoNameProvided
force-pushed
the
develop
branch
from
November 13, 2022 11:46
2ef8ff0
to
0da8f89
Compare
NoNameProvided
added
the
status: invalid / expired
Issues with no action to take.
label
Nov 20, 2022
The change is invalid, the parameter is optional. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating custom class validators,
validationOptions
can not be undefined.It gives off this error:
Type 'undefined' is not assignable to type 'ValidationOptions'.
(REF issue #1642)Correction in documentation: the validationOption argument from custom validation decorator functions is now not allowed to be optional.
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesfixes #1642