Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct typo in JSDoc for @IsHalfWidth decorator #1575

Closed
wants to merge 102 commits into from
Closed

docs: correct typo in JSDoc for @IsHalfWidth decorator #1575

wants to merge 102 commits into from

Conversation

shanehandley-lt
Copy link

Description

Correct the docblock content for the IsHalfWidth decorator which was referencing full-width

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1545

dependabot bot added 30 commits November 22, 2021 09:06
@dependabot
build(deps-dev): bump rollup from 2.60.0 to 2.60.1 (typestack#1415)
3e0b95f
@dependabot
build(deps-dev): bump lint-staged from 12.0.3 to 12.1.2 (typestack#1416)
cbcc0bb
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.2.4 to 25.3.0 (types…
81f93d0 
…tack#1419)
@dependabot
build(deps-dev): bump @types/node from 16.11.9 to 16.11.10 (typestack…
3d392a7 
…#1420)
@dependabot
build(deps-dev): bump prettier from 2.4.1 to 2.5.0 (typestack#1425)
7adbc06
@dependabot
build(deps-dev): bump rollup from 2.60.1 to 2.60.2 (typestack#1429)
701f9b9
@dependabot
build(deps-dev): bump @types/node from 16.11.10 to 16.11.11 (typestac…
699c906 
…k#1430)
@dependabot
build(deps): bump libphonenumber-js from 1.9.43 to 1.9.44 (typestack#…
3552c4c 
…1434)
@dependabot
build(deps-dev): bump prettier from 2.5.0 to 2.5.1 (typestack#1436)
a35537a
@dependabot
build(deps-dev): bump @types/node from 16.11.11 to 16.11.12 (typestac…
b546ca5 
…k#1437)
@dependabot
build(deps-dev): bump rollup from 2.60.2 to 2.61.0 (typestack#1442)
071fb68
@dependabot
build(deps-dev): bump typescript from 4.5.2 to 4.5.3 (typestack#1446)
645bc8d
@dependabot
build(deps-dev): bump rollup from 2.61.0 to 2.61.1 (typestack#1447)
aad3fea
@dependabot
build(deps-dev): bump typescript from 4.5.3 to 4.5.4 (typestack#1448)
e38968a
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.0.6 to 13.1…
e238714 
….1 (typestack#1449)
@dependabot
build(deps-dev): bump @types/node from 16.11.12 to 16.11.13 (typestac…
392eaa6 
…k#1452)
@dependabot
build(deps-dev): bump @types/node from 16.11.13 to 17.0.0 (typestack#…
57cff6d 
…1453)
@dependabot
build(deps-dev): bump @types/node from 17.0.0 to 17.0.1 (typestack#1456)
f560b16
@dependabot
build(deps-dev): bump lint-staged from 12.1.2 to 12.1.3 (typestack#1458)
4e39a04
@dependabot
build(deps-dev): bump @types/node from 17.0.1 to 17.0.2 (typestack#1459)
f3b1daa
@dependabot
build(deps-dev): bump @types/node from 17.0.2 to 17.0.4 (typestack#1461)
d8835a9
@dependabot
build(deps-dev): bump rollup from 2.61.1 to 2.62.0 (typestack#1462)
89280f7
@dependabot
build(deps-dev): bump @types/validator from 13.7.0 to 13.7.1 (typesta…
d9ab052 
…ck#1463)
@dependabot
build(deps-dev): bump @types/node from 17.0.4 to 17.0.5 (typestack#1466)
6b126e3
@dependabot
build(deps-dev): bump lint-staged from 12.1.3 to 12.1.4 (typestack#1465)
03e0f4d
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.3.0 to 25.3.2 (types…
e34028a 
…tack#1468)
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.3.2 to 25.3.3 (types…
4d93bde 
…tack#1470)
@dependabot
build(deps-dev): bump @types/jest from 27.0.3 to 27.4.0 (typestack#1472)
7123007
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.1.1 to 13.1…
a7fe601 
….2 (typestack#1471)
@dependabot
build(deps-dev): bump @types/node from 17.0.5 to 17.0.8 (typestack#1481)
d59502f
dependabot bot and others added 20 commits March 14, 2022 09:04
@dependabot
build(deps-dev): bump rollup from 2.70.0 to 2.70.1 (typestack#1582)
c72d1be
@dependabot
build(deps-dev): bump lint-staged from 12.3.5 to 12.3.6 (typestack#1584)
4d71476
@dependabot
build(deps-dev): bump prettier from 2.5.1 to 2.6.0 (typestack#1585)
7d8bd5f
@dependabot
build(deps): bump libphonenumber-js from 1.9.49 to 1.9.50 (typestack#…
303edfd 
…1589)
@dependabot
build(deps-dev): bump lint-staged from 12.3.6 to 12.3.7 (typestack#1590)
fd67e22
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.1 to 26.1.2 (types…
397473b 
…tack#1591)
@dependabot
build(deps-dev): bump @types/node from 17.0.21 to 17.0.22 (typestack#…
363a314 
…1592)
@dependabot
build(deps-dev): bump @types/node from 17.0.22 to 17.0.23 (typestack#…
4b0114d 
…1594)
@dependabot
build(deps): bump minimist from 1.2.5 to 1.2.6 (typestack#1595)
dc20354
@dependabot
build(deps-dev): bump typescript from 4.6.2 to 4.6.3 (typestack#1598)
0262804
@dependabot
build(deps-dev): bump prettier from 2.6.0 to 2.6.1 (typestack#1599)
e993a33
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.2 to 26.1.3 (types…
7098bf0 
…tack#1600)
@dependabot
build(deps-dev): bump @types/validator from 13.7.1 to 13.7.2 (typesta…
8927baa 
…ck#1602)
@dependabot
build(deps-dev): bump @rollup/plugin-commonjs from 21.0.2 to 21.0.3 (t…
b00838c 
…ypestack#1604)
@dependabot
build(deps-dev): bump prettier from 2.6.1 to 2.6.2 (typestack#1607)
ba43ec3
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.3 to 26.1.4 (types…
7befb18 
…tack#1613)
@dependabot
build(deps): bump libphonenumber-js from 1.9.50 to 1.9.51 (typestack#…
10eb3b2 
…1615)
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.1.3 to 13.2…
1dd1012 
….0 (typestack#1618)
@dependabot
build(deps-dev): bump @types/node from 17.0.23 to 17.0.24 (typestack#…
2ef8ff0 
…1619)
@shanehandley-lt
fix: Fix typo in docblock for IsHalfWidth decorator
f08dea4
@shanehandley-lt shanehandley-lt force-pushed the fix-half-width-docblock branch from debdb97 to f08dea4 Compare May 10, 2022 05:51
@braaar braaar mentioned this pull request Oct 3, 2022
Closed
@NoNameProvided
Copy link
Member

This has been fixed in c183cb3.

@NoNameProvided NoNameProvided added the status: superset by another Issue or task being tracked/handled in a different issue. label Nov 20, 2022
@NoNameProvided NoNameProvided changed the title fix: Fix typo in docblock for IsHalfWidth decorator docs: correct typo in JSDoc for @IsHalfWidth decorator Nov 20, 2022
@NoNameProvided NoNameProvided mentioned this pull request Nov 20, 2022
Closed
6 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status: superset by another Issue or task being tracked/handled in a different issue.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: IsHalfWidth docblock references IsFullWidth
2 participants
@shanehandley-lt @NoNameProvided