Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent error TS7016 by restoring @types/validator to dependencies #1568

Closed
wants to merge 102 commits into from
Closed

Conversation

KeithGillette
Copy link

Description

Restores @types/validator to dependencies rather than devDependencies in package.json so that consuming projects don't need to manually install @types/validator (which is a step not included in the README).

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [N/A] tests are added for the changes I made (if any source code was modified)
  • [N/A] documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1412 & #1535

dependabot bot added 30 commits November 22, 2021 09:06
@tahubu
Copy link

tahubu commented Apr 7, 2022

Hi @KeithGillette , in the package-lock.json file the lockfileVersion is 1 and not 2, so you are using an old version of NPM. Try to install the dependencies again with the newer version of NPM or with Node v14/v16.

@KeithGillette
Copy link
Author

Thanks, @tahubu. I was using [email protected] / [email protected]. I rebased on develop and used [email protected] / [email protected] to update the PR.

@KeithGillette
Copy link
Author

Hi, @tahubu — Can this PR be reviewed? Thanks.

@aleccool213
Copy link

I would appreciate this be looked at and merged as this is breaking TypeScript builds when upgrading to the new version. This is very hard to debug for newbies.

@NoNameProvided NoNameProvided added the status: superset by another Issue or task being tracked/handled in a different issue. label Nov 20, 2022
@NoNameProvided
Copy link
Member

Fixed and landed in 12f8d86.

(I don't allow contributions to package-lock.json due to security reasons.)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: superset by another Issue or task being tracked/handled in a different issue.
5 participants