-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent error TS7016 by restoring @types/validator
to dependencies
#1568
Conversation
Hi @KeithGillette , in the |
Thanks, @tahubu. I was using |
Hi, @tahubu — Can this PR be reviewed? Thanks. |
I would appreciate this be looked at and merged as this is breaking TypeScript builds when upgrading to the new version. This is very hard to debug for newbies. |
2ef8ff0
to
0da8f89
Compare
Fixed and landed in 12f8d86. (I don't allow contributions to |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Restores
@types/validator
todependencies
rather thandevDependencies
inpackage.json
so that consuming projects don't need to manually install@types/validator
(which is a step not included in the README).Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #1412 & #1535