Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read nullable option in @IsNotEmptyObject decorator correctly #1555

Merged
merged 2 commits into from
Dec 15, 2022
Merged

fix: read nullable option in @IsNotEmptyObject decorator correctly #1555

merged 2 commits into from
Dec 15, 2022

Conversation

arkist
Copy link
Contributor

@arkist arkist commented Feb 17, 2022 •
edited
Loading

Description

Fixing @IsNotEmptyObject-nullable option's behavior and test case.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1554

@braaar braaar mentioned this pull request Oct 3, 2022
Closed
@NoNameProvided NoNameProvided force-pushed the fix/isNotEmptyObject-nullable branch from 33be210 to 5369c7b Compare December 3, 2022 14:30
@NoNameProvided NoNameProvided changed the title fix: isNotEmptyObject nullable option works opposite way fix: read nullable option in @IsNotEmptyObject decorator correctly Dec 15, 2022
@NoNameProvided NoNameProvided merged commit 8105b67 into typestack:develop Dec 15, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NoNameProvided NoNameProvided NoNameProvided approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: isNotEmptyObject nullable option works opposite way
2 participants
@arkist @NoNameProvided