Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update 'no metadata found' error message #1127

Closed
wants to merge 96 commits into from
Closed

Fix: update 'no metadata found' error message #1127

wants to merge 96 commits into from

Conversation

capndave
Copy link

Description

Update the following error: No metadata found. There is more than once class-validator version installed probably. You need to flatten your dependencies.

  • Update the error message with correct grammar
  • Add a sentence explaining that validation flags are expected but not present in the code.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1124

dependabot bot added 30 commits March 23, 2021 17:40
dependabot bot and others added 20 commits June 1, 2021 08:10
- fix grammatical errors
- add unused flag description
@capndave
Copy link
Author

capndave commented Jun 11, 2021

@typestack @MichalLytek @jotamorais how do I get this to pass the semantic PR check? Have been fooling with it for over an hour and still won't pass

@lukeca362
Copy link

@capndave try editing the PR title to lowercase F
i.e. fix: update 'no metadata found' error message

@braaar
Copy link
Member

braaar commented Oct 3, 2022

@capndave could you rebase/merge this and get rid of the irrelevant changes?

@NoNameProvided
Copy link
Member

Fixed in f6f1bdf. I did not understand the second reason, so I slightly modified the proposed message.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants