Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update isPostalCode locale codes note #1044

Conversation

StefSmit12
Copy link

Description

Updated the locale codes note of isPostalCode, because not every possible locale code was in the notes.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1043

dependabot bot added 30 commits March 23, 2021 17:40
@braaar
Copy link
Member

braaar commented Sep 30, 2022

Could you rebase/merge this PR to get rid of irrelevant changes and double check that the docstring is still up to date?

@braaar
Copy link
Member

braaar commented Oct 3, 2022

@StefSmit12 could you rebase/merge and get rid of the irrelevant changes in this PR?

@braaar
Copy link
Member

braaar commented Oct 4, 2022

Hi @StefSmit12, could you rebase/merge this to get rid of irrelevant changes?

@NoNameProvided
Copy link
Member

Thanks, I actually went the other way and removed the hard-coded JSDoc list. The function is typed so users will always see the up-to-date list of options as code completion.

Landed in cf8d2c0.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: Missing some locale codes in note
3 participants