-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update isPostalCode locale codes note #1044
Fix: Update isPostalCode locale codes note #1044
Conversation
acb7de1
to
c6984bb
Compare
Could you rebase/merge this PR to get rid of irrelevant changes and double check that the docstring is still up to date? |
@StefSmit12 could you rebase/merge and get rid of the irrelevant changes in this PR? |
Hi @StefSmit12, could you rebase/merge this to get rid of irrelevant changes? |
Thanks, I actually went the other way and removed the hard-coded JSDoc list. The function is typed so users will always see the up-to-date list of options as code completion. Landed in cf8d2c0. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Updated the locale codes note of isPostalCode, because not every possible locale code was in the notes.
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #1043