Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support typescript 3.6 #916

Merged
merged 5 commits into from
Sep 2, 2019
Merged

chore: support typescript 3.6 #916

merged 5 commits into from
Sep 2, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Aug 29, 2019

plus bump other deps
Fixes #932
Fixes #935

Ignored a bunch of new ast-alignment failures from both bumping @babel/parser to 7.5.5, as well as ts to 3.6.x

plus bump other deps
@bradzacher bradzacher requested a review from JamesHenry August 29, 2019 00:58
@typescript-eslint typescript-eslint deleted a comment from typescript-eslint bot Aug 29, 2019
@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Aug 29, 2019
@deser

This comment has been minimized.

@bradzacher

This comment has been minimized.

@deser

This comment has been minimized.

@JamesHenry
Copy link
Member

@bradzacher Let's add it to the things we ignore for now, we can loop back to the AST alignment testing later.

Let me know once this is ready to go and we'll get it merged!

# Conflicts:
#	packages/eslint-plugin/package.json
#	packages/experimental-utils/package.json
#	packages/parser/package.json
@JamesHenry JamesHenry merged commit 0f63e3f into master Sep 2, 2019
@JamesHenry JamesHenry deleted the bump-deps-aug-2019 branch September 2, 2019 19:40
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #916 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   94.09%   94.05%   -0.04%     
==========================================
  Files         113      113              
  Lines        4929     4931       +2     
  Branches     1375     1376       +1     
==========================================
  Hits         4638     4638              
- Misses        165      166       +1     
- Partials      126      127       +1
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/quotes.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/require-await.ts 92.68% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 96.36% <0%> (-3.64%) ⬇️
packages/eslint-plugin/src/rules/no-type-alias.ts 94.54% <100%> (ø) ⬆️
packages/typescript-estree/src/parser.ts 93.05% <100%> (ø) ⬆️

anandaroop added a commit to anandaroop/typescript-eslint that referenced this pull request Sep 6, 2019
Update the docs to match the change (<3.7.0) in typescript-eslint#916
anandaroop added a commit to anandaroop/typescript-eslint that referenced this pull request Sep 6, 2019
Update the docs to match the change in typescript-eslint#916 (i.e. support up to  <3.7.0)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly support TypeScript 3.6 Security alert eslint-utils
3 participants