-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support typescript 3.6 #916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus bump other deps
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bradzacher Let's add it to the things we ignore for now, we can loop back to the AST alignment testing later. Let me know once this is ready to go and we'll get it merged! |
# Conflicts: # packages/eslint-plugin/package.json # packages/experimental-utils/package.json # packages/parser/package.json
JamesHenry
approved these changes
Sep 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 94.09% 94.05% -0.04%
==========================================
Files 113 113
Lines 4929 4931 +2
Branches 1375 1376 +1
==========================================
Hits 4638 4638
- Misses 165 166 +1
- Partials 126 127 +1
|
1 task
anandaroop
added a commit
to anandaroop/typescript-eslint
that referenced
this pull request
Sep 6, 2019
Update the docs to match the change (<3.7.0) in typescript-eslint#916
anandaroop
added a commit
to anandaroop/typescript-eslint
that referenced
this pull request
Sep 6, 2019
Update the docs to match the change in typescript-eslint#916 (i.e. support up to <3.7.0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus bump other deps
Fixes #932
Fixes #935
Ignored a bunch of new ast-alignment failures from both bumping
@babel/parser
to 7.5.5, as well as ts to 3.6.x