Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): update recommended configs #3809

Merged

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Aug 29, 2021

BREAKING CHANGE: recommended configs are changed


Part of #3738
Part of #3746

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey force-pushed the update-recommended-config branch 2 times, most recently from bf7e525 to 082c568 Compare August 29, 2021 02:10
@MichaelDeBoey MichaelDeBoey force-pushed the update-recommended-config branch 5 times, most recently from b062183 to 80bd4c8 Compare August 29, 2021 13:43
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this doesn't fully resolve #3646 because there is a few default rule option change that we need to make to ban-types - remove the object type.

So if you want to do that here, that's great - or else we can do a separate PR.

Otherwise - need to remove that one thing which I messed up, and fix the CI - then this is good to go.

@bradzacher bradzacher added breaking change This change will require a new major version to be released enhancement New feature or request recommended-rules Discussion about recommended rule sets labels Aug 29, 2021
@bradzacher bradzacher added this to the 5.0.0 milestone Aug 29, 2021
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 29, 2021
BREAKING CHANGE: recommended configs are changed
@MichaelDeBoey MichaelDeBoey changed the title feat(eslint-plugin): update recommended sets feat(eslint-plugin): update recommended configs Aug 29, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the update-recommended-config branch from cf309d9 to 60e1ca5 Compare August 29, 2021 23:49
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Aug 29, 2021

Note that this doesn't fully resolve #3646 because there is a few default rule option change that we need to make to ban-types - remove the object type.

@bradzacher I'll do that in a follow-up PR: #3818

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 30, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request recommended-rules Discussion about recommended rule sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants