-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove meta.docs.category
from rules
#3800
feat: remove meta.docs.category
from rules
#3800
Conversation
Thanks for the PR, @MichaelDeBoey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
7d447ab
to
00e8efa
Compare
let's just remove it from everywhere. |
meta.docs.category
in core rulesmeta.docs.category
from rules
1dabec2
to
3d22078
Compare
@bradzacher Removed the |
Codecov Report
@@ Coverage Diff @@
## v5 #3800 +/- ##
==========================================
- Coverage 92.55% 92.55% -0.01%
==========================================
Files 325 323 -2
Lines 11247 11240 -7
Branches 3174 3174
==========================================
- Hits 10410 10403 -7
Misses 384 384
Partials 453 453
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3d22078
to
44b97b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
@bradzacher Not sure if wanted to remove it from all rules or only from the extended core rules, so went with the latter (for now).
Types will be less complex if we remove it on all rules though.
Part of #3738