This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Restore binary backwards compatibility of Inputs.create method. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @jsuereth. |
gkossakowski
added a commit
that referenced
this pull request
Aug 24, 2014
Restore binary backwards compatibility of Inputs.create method.
|
Merging without review because @jsuereth is on vacation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Inputs.createmethod has been modified by60c7e4d to add support for IncOptions.
That broke both binary and source compatibility. Let's restore the old
signature for Inputs.create and deprecate it at the same time.
Fixes another instance of #44.