Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flatten): accept depth-3 array #362

Merged
merged 1 commit into from
Dec 21, 2017
Merged

feat(flatten): accept depth-3 array #362

merged 1 commit into from
Dec 21, 2017

Conversation

ikatyang
Copy link
Member

Context: #356 (comment)

@ikatyang ikatyang mentioned this pull request Dec 21, 2017
Closed
KiaraGrouwstra
KiaraGrouwstra approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@KiaraGrouwstra KiaraGrouwstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough; I'd thought about generalized recursive approaches before, but this seems a fair compromise for the time being.

@ikatyang ikatyang merged commit dfcadbd into master Dec 21, 2017
@ikatyang ikatyang deleted the feat/flatten-depth-3 branch December 21, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiaraGrouwstra KiaraGrouwstra KiaraGrouwstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @KiaraGrouwstra