-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With optional it does not work with null #20
base: master
Are you sure you want to change the base?
Conversation
Using |
Yeah, any alternative solution? |
Not that I know of, I've worked around it in other places by using |
AFAIK |
@louy Sorry, I didn't understand that notation? |
Sorry. I meant In TS 1.8 function test(x: void) {}
test(null); // <-- no errors |
I've just realised that the problem @unional is having is with TS nightly as I don't think we can do anything about this for now to make it work with both versions. Anyway non-nullable types are a version 2.0 feature so I think we don't have to worry about them for now. |
@louy yeah, notice that it is working fine when I actually open this project and run the tests. Wouldn't it be a backward compatibility issue with nullable type? Seems like this will break a lot of typings when TS 2.0 is released. |
Absolutely, it kind of does - but that's what a 2.0 is for, I suppose. I've been having a pretty good run using |
No description provided.