Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slideshow navigation update and update React version #248

Merged
merged 2 commits into from
Jul 12, 2016
Merged

Slideshow navigation update and update React version #248

merged 2 commits into from
Jul 12, 2016

Conversation

nickhsine
Copy link
Collaborator

@nickhsine nickhsine commented Jul 11, 2016 •
edited
Loading

Update React is due to this

@garfieldduck

@hsunpei
Copy link
Contributor

hsunpei commented Jul 11, 2016

LGTM :shipit:

@nickhsine
Update several files
44f3fbd 
- make article components rendered by device as well
- upgrade eslint version
- some style tuning
@nickhsine
Copy link
Collaborator Author

@garfieldduck @hcchien
照之前說的，增加了 device ，讓需要的 component 可以 render by device。

@hcchien
Copy link
Contributor

hcchien commented Jul 11, 2016

LGTM

@hsunpei
Copy link
Contributor

hsunpei commented Jul 11, 2016

👍

@nickhsine nickhsine merged commit d3ec8ba into twreporter:revamp Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickhsine @hsunpei @hcchien