-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to go modules #287
Conversation
Using The main issue with Twirp is that the generated code has some dependencies on the Maybe think using |
I'm afraid even that is impossible.
If you merge this PR then two things will happen: When a user If a user explicitly go gets a So if this PR is merged and a tag is created, it will just end up breaking everything if I'm looking at things correctly. |
The semantic versioning restriction in |
You really don't want to do that either as this will not be proper semver according to Go's definition of semver. And people who might try to I think the only path forward here is to adapt Go Modules the right way or to not adapt it at all. |
Thanks for the input @marwan-at-work. Definitely sound likes we'll have to attempt a full migration if we would like to get this working and that's much hairier. I'll close this PR. |
This partially resolves - particularly the concerns around requiring
retool
#169The tooling will still need to be updated but this enables that and easier management of dependencies.
Description of Changes
Initializes the
go.mod
configuration and removes thedep
and vendor folders.We still are using the
+incompatible
versions but that will be addressed in another PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.