Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.7.0-alpha.1 #277

Merged
merged 4 commits into from
Oct 23, 2022
Merged

release 0.7.0-alpha.1 #277

merged 4 commits into from
Oct 23, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis added the release Mark pr as a release label Oct 23, 2022
@Emilgardis Emilgardis changed the title fix/remove old config value release 0.7.0-alpha.1 Oct 23, 2022
@Emilgardis
Copy link
Member Author

Emilgardis commented Oct 23, 2022

might have to disable scrape-examples, will have to see

@Emilgardis Emilgardis force-pushed the release-0.7.0-alpha.1 branch from 6d0a4d0 to 832f947 Compare October 23, 2022 20:15
@Emilgardis
Copy link
Member Author

bors r+

:shipit:

@bors
Copy link
Contributor

bors bot commented Oct 23, 2022

Build succeeded:

@bors bors bot merged commit 1e2512b into main Oct 23, 2022
@bors bors bot deleted the release-0.7.0-alpha.1 branch October 23, 2022 20:43
@Emilgardis
Copy link
Member Author

Emilgardis commented Oct 23, 2022

It worked!

https://docs.rs/twitch_api/0.7.0-alpha.1/twitch_api/client/trait.ClientDefault.html#method.default_client

edit: kinda, no eventsub examples and no builds of the workspace deps.

https://docs.rs/crate/twitch_api/0.7.0-alpha.1/builds/655375

@Emilgardis
Copy link
Member Author

Emilgardis commented Oct 23, 2022

alright, it's probably not possible to support this.

cargo publish strips away workspace members. See https://doc.rust-lang.org/cargo/commands/cargo-package.html#description

This however doesn't describe how they are stripped away, should maybe ask about this upstream and in docs.rs about how this would work

edit: cargo publish tarballs the package, and the workspace members are not considered part of that package

commented this here rust-lang/rust#88791 (comment)

@simonsan
Copy link

simonsan commented Oct 24, 2022

alright, it's probably not possible to support this.

cargo publish strips away workspace members. See https://doc.rust-lang.org/cargo/commands/cargo-package.html#description

This however doesn't describe how they are stripped away, should maybe ask about this upstream and in docs.rs about how this would work

edit: cargo publish tarballs the package, and the workspace members are not considered part of that package

commented this here rust-lang/rust#88791 (comment)

https://lib.rs/crates/cargo-smart-release

I think that is the way no? Release and publish each workspace member singly then?

@Emilgardis
Copy link
Member Author

Emilgardis commented Oct 24, 2022

I think that is the way no? Release and publish each workspace member singly then?

I'm not sure I understand, why would we publish the examples?

edit: it wouldn't even work for scraping examples, as the examples/reverse-deps need to be in the workspace root for --rustdoc-scrape-examples=all to consider them

@simonsan
Copy link

I think that is the way no? Release and publish each workspace member singly then?

I'm not sure I understand, why would we publish the examples?

edit: it wouldn't even work for scraping examples, as the examples/reverse-deps need to be in the workspace root for --rustdoc-scrape-examples=all to consider them

I thought more for general publishing of workspace members, not the examples. Maybe I misunderstood the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Mark pr as a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants