Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onError to GithubService #382

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add onError to GithubService #382

merged 1 commit into from
Nov 11, 2024

Conversation

fishshi
Copy link
Collaborator

@fishshi fishshi commented Nov 11, 2024

#378 add a error prompt output using onError, and I add the missing onError to GithubService.
Should be merged after #378.

@yuzcat01
Copy link
Collaborator

LGTM
Yeah, you're right, I didn't take that into account

rjmacarthy
rjmacarthy approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@rjmacarthy rjmacarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is probably a better way thinking about it now than to use errorMessage property as it gets added in the conversation history. Perhaps we can just use vscode notification and keep conversation history clean...not sure. Many thanks!

@rjmacarthy rjmacarthy changed the base branch from main to development November 11, 2024 09:18
@rjmacarthy rjmacarthy merged commit b0ea71d into twinnydotdev:development Nov 11, 2024
@fishshi fishshi deleted the fix/add_onError_to_GithubService branch November 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzcat01 yuzcat01 yuzcat01 approved these changes

@rjmacarthy rjmacarthy rjmacarthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishshi @yuzcat01 @rjmacarthy