haskell_toolchain tools as a list #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboes
approved these changes
Apr 30, 2019
`haskell_toolchain` `tools` attribute is now a list of labels. Binaries (such as `ghc`, `haddock`, ...) are now located in this list, first entries take precedence. This is a backward incompatible change, but the conversion of repository is trivial (i.e. add list bracket on your `tools` attribute). Closes #848
|
Thanks. The build failure is trivial (a new instance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell_toolchaintoolsattribute is now a list oflabels. Binaries (such as
ghc,haddock, ...) are now located inthis list, first entries take precedence.
This is a backward incompatible change, but the conversion of
repository is trivial (i.e. add list bracket on your
toolsattribute).Closes #848