Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make providers.bzl public #844

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Make providers.bzl public #844

merged 1 commit into from
Apr 29, 2019

Conversation

mboes
Copy link
Member

@mboes mboes commented Apr 25, 2019

Providers are everything but private. They should be considered an
integral part of the interface of a rule. Any downstream dependencies
are free to query the providers passed to them and poke at each of
their fields. We should carefully consider any changes to providers,
because changing providers means changing the interface of a rule.

We can allow ourselves sweeping changes to the providers ahead of the
next release, because they were marked private previously (even if
abusively). But after that, we'll have to be a lot more careful. We
may consider marking some providers as "experimental" for some time
(like Bazel does).

Providers are everything but private. They should be considered an
integral part of the interface of a rule. Any downstream dependencies
are free to query the providers passed to them and poke at each of
their fields. We should carefully consider any changes to providers,
because changing providers means changing the interface of a rule.
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mboes mboes merged commit 8e336ad into master Apr 29, 2019
@mboes mboes deleted the providers-reorg branch April 29, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants