Full CC/Haskell/CC sandwich using CC Skylark API #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had the full sandwich previously, but it relied on two wrapper rules, `cc_haskell_import` and `haskell_cc_import` along with various hacks in order to do the job. Both of those rules are now deprecated. Haskell rules now return a `CcInfo` provider the way any `cc_library` does.
aherrmann
reviewed
Apr 16, 2019
There was a problem hiding this comment.
That's great! I'm all for it.
Though, previously CcInfo in dep would never be True for haskell_library targets and the like. Now it is. I'm not sure about the implications of this. E.g. in cc_interop_info Haskell libraries will now be included in the resulting CcInfo. That may not be what we want. There might be more occurrences of this in the code base.
Haskell and CC libraries now both return a `CcInfo` provider. But the CC interop machinery was designed to gather data about CC libraries specifically, even though in principle there should be little difference. Out of precaution, ahead of a refactor getting rid of the interop machinery altogether, we gather `CcInfo`'s that do not have a `HaskellBuildInfo`.
|
I have pushed a new commit excluding haskell libraries from the interop logic, out of precaution. The interop logic should really just go away at this point. We should be treating Haskell and CC libraries uniformly as far as linking is concerned. But that will be a pretty massive refactor - for later PR's. |
Profpatsch
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the full sandwich previously, but it relied on two wrapper
rules,
cc_haskell_importandhaskell_cc_importalong with varioushacks in order to do the job. Both of those rules are now deprecated.
Haskell rules now return a
CcInfoprovider the way anycc_librarydoes.