Add support for GHC plugins #799
Conversation
mboes
force-pushed
the
plugins
branch
5 times, most recently
from
cb217e8 to
df8de05
Compare
| @@ -236,7 +244,11 @@ def _haskell_binary_common_impl(ctx, is_test): | |||
|
|
|||
| def haskell_library_impl(ctx): | |||
| hs = haskell_context(ctx) | |||
| dep_info = gather_dep_info(ctx) | |||
| dep_info = gather_dep_info(ctx, ctx.attr.deps) | |||
There was a problem hiding this comment.
There is a code duplication here.
| @@ -66,7 +66,11 @@ def _should_inspect_coverage(ctx, hs, is_test): | |||
|
|
|||
| def _haskell_binary_common_impl(ctx, is_test): | |||
| hs = haskell_context(ctx) | |||
| dep_info = gather_dep_info(ctx) | |||
| dep_info = gather_dep_info(ctx, ctx.attr.deps) | |||
There was a problem hiding this comment.
@guibou What is duplicated here is one list comprehension in two places. See what our coding guidelines have to say about that (that part originally from the GHC coding style document).
| @@ -17,7 +17,7 @@ load(":private/actions/package.bzl", "package") | |||
|
|
|||
| _GHC_BINARIES = ["ghc", "ghc-pkg", "hsc2hs", "haddock", "ghci", "runghc", "hpc"] | |||
|
|
|||
| def _run_ghc(hs, cc, inputs, outputs, mnemonic, arguments, params_file = None, env = None, progress_message = None): | |||
| def _run_ghc(hs, cc, inputs, outputs, mnemonic, arguments, params_file = None, env = None, progress_message = None, input_manifests = None): | |||
| @@ -96,6 +96,7 @@ def _run_ghc(hs, cc, inputs, outputs, mnemonic, arguments, params_file = None, e | |||
|
|
|||
| hs.actions.run_shell( | |||
| inputs = inputs, | |||
| input_manifests = input_manifests, | |||
There was a problem hiding this comment.
It's an argument to run_shell(), so it's documented in the API documentation for run_shell().
There was a problem hiding this comment.
Nevermind. I was just surprised to discover new arguments to run_shell and _run_ghc which were not used elsewhere in this PR.
There was a problem hiding this comment.
Ah, you're right. They're used in a followup PR (not submitted yet). Though that extra argument does no harm at this point.
It's an implicit dependency of the `ghc` library.
This introduces new `ghc_plugin` rule type, and an extra attribute to `haskell_*` rules to add plugins to the compilation process. Plugins only affect the compile action, not any other action. We take care to ensure that plugin dependencies do not induce extra runtime dependencies, by using `-plugin-package` for plugin dependencies instead of `-package`.
This introduces new
ghc_pluginrule type, and an extra attribute tohaskell_*rules to add plugins to the compilation process. Pluginsonly affect the compile action, not any other action. We take care to
ensure that plugin dependencies do not induce extra runtime
dependencies, by using
-plugin-packagefor plugin dependenciesinstead of
-package.