Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Consider using parse5 for fully standard-compliant HTML parsing #249

Closed
cvrebert opened this issue Feb 24, 2015 · 3 comments
Closed

Consider using parse5 for fully standard-compliant HTML parsing #249

cvrebert opened this issue Feb 24, 2015 · 3 comments
Labels
wontfix

Comments

@cvrebert
Copy link
Collaborator

As inikulin/parse5#30 has now been fixed, we should consider using parse5 with cheerio, as parse5 is fully standard-compliant, whereas htmlparser2 has some known issues that make it non-compliant.
@cvrebert
Copy link
Collaborator Author

Well, there's https://github.com/inikulin/whacko, a Cheerio fork that uses parse5, but there might be ecosystem drawbacks.

@kkirsche
Copy link
Contributor

I'd be happy to convert to whacko but it throws an error for example with the following fixture for Document declares a non-HTML5 DOCTYPE for:
https://github.com/twbs/bootlint/blob/master/test/fixtures/doctype/html5-legacy.html#L1

I want to make sure that the tests won't throw other errors we aren't expecting and that it won't create problem in place of cheerio.

kkirsche pushed a commit to kkirsche/bootlint that referenced this issue Feb 28, 2015
[Fixes twbs#249] Use parse5 for standard-compliant parsing
c421645 
[Fixes twbs#249] Use parse5 for standard-compliant parsing
@kkirsche kkirsche mentioned this issue Feb 28, 2015
Closed
kkirsche pushed a commit to kkirsche/bootlint that referenced this issue Feb 28, 2015
[Fixes twbs#249] Use parse5 for standard-compliant parsing
0a42498 
[Fixes twbs#249] Use parse5 for standard-compliant parsing

New shrinkwrap file for NPM

Fix variable names
@cvrebert
Copy link
Collaborator Author

cvrebert commented Mar 1, 2015

Closing per #251 (comment)

@cvrebert cvrebert closed this as completed Mar 1, 2015
@cvrebert cvrebert mentioned this issue Feb 27, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #249] Use parse5 for standard-compliant parsing kkirsche/bootlint
2 participants
@cvrebert @kkirsche