Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: n-modal has log warnings of console when use aria-hidden attribute. #6569

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix: n-modal has log warnings of console when use aria-hidden attribute. #6569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38dd2c3
fix: Modal warning issue
puxiao Nov 27, 2024
0a75798
update CHANGELOG
puxiao Nov 27, 2024
07d83f4
update CHANGELOG
puxiao Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fix `n-time-picker`'s `use-12-hours` type error warning, closes [#4308](https://github.com/tusen-ai/naive-ui/issues/4308)
- Fix `input-number` the problem that the negative sign is replaced when the negative sign is entered.
- Fix `n-data-table`'s header will show scrollbar in some old browsers, closes [#6557](https://github.com/tusen-ai/naive-ui/issues/6557).
- Fix `n-modal` has log warnings of console when use `aria-hidden` attribute, closes [#6436](https://github.com/tusen-ai/naive-ui/issues/6436)

### Features

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- `n-time-picker` 的 `use-12-hours` 类型错误警告，关闭 [#4308](https://github.com/tusen-ai/naive-ui/issues/4308)
- 修复 `input-number` 存在负号时被替换的问题
- 修复 `n-data-table` 的 header 在部分浏览器中会出现滚动条，关闭 [#6557](https://github.com/tusen-ai/naive-ui/issues/6557)
- 修复 `n-modal` 中 `aria-hidden` 属性引发的控制台报警告，关闭 [#6436](https://github.com/tusen-ai/naive-ui/issues/6436)

### Features

Expand Down
1 change: 0 additions & 1 deletion src/modal/src/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@ export default defineComponent({
default: () => {
return this.show ? (
<div
aria-hidden
ref="containerRef"
class={`${mergedClsPrefix}-modal-mask`}
onClick={this.handleClickoutside}
Expand Down