Turn off naming convention eslint rules #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcd
force-pushed
the
etcd/turn-off-naming-convention-rules
branch
2 times, most recently
from
d322a9a to
8c6abcb
Compare
etcd
force-pushed
the
etcd/turn-off-naming-convention-rules
branch
from
8c6abcb to
7d527d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the naming convention rules as they would cause breaking changes in the API of the existing SDK.
Discussed with Morgan about including all the simple linting/formatting changes directly in this PR. For the most part, they consist of the following:
type->interfacelet->const(where possible)any->unknown(where possible)