Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to catkin build system #76

Open
dtmoodie opened this issue Mar 5, 2015 · 11 comments
Open

Move to catkin build system #76

dtmoodie opened this issue Mar 5, 2015 · 11 comments

Comments

@dtmoodie
Copy link

dtmoodie commented Mar 5, 2015

Please port to catkin build system to work with newer ROS installs.

@icoderaven
Copy link

Can you please confirm that pull request #70 works for you?

@colek42
Copy link

colek42 commented Mar 20, 2015

your fork works for me on 14.04, indego. Thanks!

@chrisspen
Copy link

@icoderaven, Your fork doesn't compile for me on 14.04, Indigo. I get the error:

In file included from /home/chris/git/lsd_slam_test/src/lsd_slam/lsd_slam_viewer/src/main_viewer.cpp:25:0:
/home/chris/git/lsd_slam_test/src/lsd_slam/lsd_slam_viewer/src/PointCloudViewer.h:30:41: fatal error: lsd_slam_viewer/keyframeMsg.h: No such file or directory
 #include "lsd_slam_viewer/keyframeMsg.h"
                                         ^
compilation terminated.
In file included from /home/chris/git/lsd_slam_test/src/lsd_slam/lsd_slam_viewer/src/PointCloudViewer.cpp:22:0:
/home/chris/git/lsd_slam_test/src/lsd_slam/lsd_slam_viewer/src/PointCloudViewer.h:30:41: fatal error: lsd_slam_viewer/keyframeMsg.h: No such file or directory
 #include "lsd_slam_viewer/keyframeMsg.h"

@icoderaven
Copy link

Hm, this is a common issue with the message headers not compiling before the executables. I have a version of the CMakelists.txt that forces the build of the messages first. A temporary way to get it to build is to use a smaller number of parallel threads while building the package. I'll see if I can push that commit sometime.

@chrisspen
Copy link

Yeah, googling found me this similar question, which mentions this bug in catkin. I worked around it by running catkin twice like:

catkin_make -j1
catkin_make

which feels a little hacky.

Yes, please push your fixed CMakeLists.txt when you're able.

@oblivione
Copy link

cd lsd_slam/

git checkout catkin
you run " ls"

response should :

LICENSE lsd_slam lsd_slam_core lsd_slam_viewer README.md

Then add
"build_depend>cmake_modules</build_depend"

"run_depend>cmake_modules</run_depend"

in "package.xml" both in the folder "lsd_slam/lsd_slam_viewer" and in the folder "lsd_slam/lsd_slam_core".

In "CMakeFiles.txt" both in the folder "lsd_slam/lsd_slam_viewer" and in the folder "lsd_slam/lsd_slam_core"

add:
find_package(cmake_modules REQUIRED)

check the line below (X11 may be mising )
target_link_libraries(lsdslam ${FABMAP_LIB} ${G2O_LIBRARIES} ${catkin_LIBRARIES} csparse cxsparse X11)

Then u can build your workspace by
cd path_to_catkin_ws
catkin_make

Then again if got some error of header file missing then
"CMakeFiles.txt" in the folder "lsd_slam/lsd_slam_core" add:
add_dependencies(lsdslam lsd_slam_viewer_generate_messages_cpp)
add_dependencies(live_slam lsd_slam_viewer_generate_messages_cpp)
add_dependencies(dataset lsd_slam_viewer_generate_messages_cpp)

"CMakeFiles.txt" in the folder "lsd_slam/lsd_slam_viewer" add:
add_dependencies(viewer lsd_slam_viewer_generate_messages_cpp)

@romdos
Copy link

romdos commented Oct 29, 2016

I have the next error:
~/ros_workspace/catkin/src/lsd_slam/lsd_slam_core/src/GlobalMapping/g2oTypeSim3Sophus.h:24:34: fatal error: g2o/core/base_vertex.h: No such file or directory
compilation terminated.

@apesIITM
Copy link

apesIITM commented Mar 18, 2017

@oblivione @JakobEngel @icoderaven following the same steps, it gave this error [Eigen]:
=-=-=-=-=-=-=-=
`By not providing "FindEigen.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Eigen", but
CMake did not find one.

Could not find a package configuration file provided by "Eigen" with any
of the following names:

EigenConfig.cmake
eigen-config.cmake

Add the installation prefix of "Eigen" to CMAKE_PREFIX_PATH or set
"Eigen_DIR" to a directory containing one of the above files. If "Eigen"
provides a separate development package or SDK, be sure it has been
installed.`
=-=-=-=-=-=-=-=

@romdos
Copy link

romdos commented Mar 18, 2017

You must set a path to Eigen library.

@Toumi0812
Copy link

Hi @oblivione,
How to find "path_to_catkin_ws" ?

Thanks

@20chix
Copy link

20chix commented Jan 20, 2019

I have the next error:
~/ros_workspace/catkin/src/lsd_slam/lsd_slam_core/src/GlobalMapping/g2oTypeSim3Sophus.h:24:34: fatal error: g2o/core/base_vertex.h: No such file or directory
compilation terminated.

I'm getting similar error did you fixed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants