Add a button to record new samples #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasGocht
requested changes
Jun 17, 2022
| self.session.setRecorder(self.recorder) | ||
| self.recorder.setMediaFormat(QMediaFormat.Wave) | ||
| self.recorder.setEncodingMode(QMediaRecorder.ConstantBitRateEncoding) | ||
| self.recorder.setAudioSampleRate(16000) |
There was a problem hiding this comment.
I suppose to record and save in full quality, e.g. 48000 kHz, and then reduce the sample rate later for training and inference
| self.recorder.setMediaFormat(QMediaFormat.Wave) | ||
| self.recorder.setEncodingMode(QMediaRecorder.ConstantBitRateEncoding) | ||
| self.recorder.setAudioSampleRate(16000) | ||
| self.recorder.setAudioBitRate(32) |
There was a problem hiding this comment.
I think 16 Bit is the standard here, but I am unsure.
| if not self.project.audio_folder or not self.project.audio_folder.is_dir(): | ||
| return | ||
| if self.recorder.recorderState() == QMediaRecorder.StoppedState: | ||
| name = "000" + "".join(random.choices("0123456789abcdef", k=125)) |
There was a problem hiding this comment.
random is difficult, as it might happen at random, that the same value is chosen, which might lead to bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Todo:
Future work: