Fix stream creation concurrency in new_stream #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 38.99% 38.96% -0.03%
==========================================
Files 28 28
Lines 2090 2089 -1
==========================================
- Hits 815 814 -1
Misses 1275 1275
Continue to review full report at Codecov.
|
The stream concurrency fix had only been taken into use in grpcbox_client_stream:send_request. This commit adds the fix also to grpcbox_client_stream:new_stream.
psalin
force-pushed
the
fix_stream_creation_concurrency
branch
from
4422af8 to
e4fd229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream concurrency fix for joedevivo/chatterbox#136 had only been taken into use in
grpcbox_client_stream:send_request. This commit adds the fix also
to grpcbox_client_stream:new_stream.