Webext support #185
Merged
Webext support #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2019
|
I have tested this in the latest versions of firefox and chrome. |
Closed
DJWassink
approved these changes
Feb 22, 2019
|
Thanks @DJWassink ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally went ahead and added the webext support in #65 . Instead of using a polyfill, I just included a util that falls back to the
browserAPI if thechromenamespace is not present. Reasoning is presented in #65.Additionally, I went ahead and made a default for
portNameoptions so it doesn't need to be specified explicitly. Fixes #184.