Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates and drop Node 14 #507

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Dependency updates and drop Node 14 #507

merged 2 commits into from
Aug 11, 2023

Conversation

tschaub
Copy link
Owner

@tschaub tschaub commented Aug 11, 2023 •
edited
Loading

This change updates commander to make use of the requiredOption function for the --dist option.

tschaub
tschaub commented Aug 11, 2023
View reviewed changes
test/bin/gh-pages.spec.js
args: ['.'],
error:
'No base directory specified. The `--dist` option must be specified.',
},
Copy link
Owner Author

@tschaub tschaub Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test case because commander now exits when the --dist option is not provided.

@tschaub tschaub changed the title Make dist a required option Dependency updates and drop Node 14 Aug 11, 2023
@tschaub tschaub merged commit 07cece3 into main Aug 11, 2023
@tschaub tschaub deleted the updates branch August 11, 2023 04:07
@Sunita-7869 Sunita-7869 mentioned this pull request May 25, 2024
Open
@gardnern gardnern mentioned this pull request Jun 18, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tschaub