fix: make the default config work properly #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a property in the config-object exists but is undefined, the Object.assign on the following line will not pick the default property, but instead the (undefined) property of the config-object.
|
@tschaub any updates on this? Do you need anything more before merging this fix? |
|
Thanks for the proposed change and for bringing this to my attention. The [email protected] release includes a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #308
After
2fb83f5#diff-6eec2f2dfcb5bb90afa10af53927034bR83
the "git"-property will always exist on the config-object, even if the value of it is undefined.
In that case, the
Object.assign()in lib/index.js:52 will not pick the default property, but instead the (undefined) property of the config-object.This PR fixes the issue by removing all undefined properties from the config object, allowing the default-properties to properly take over.